Fix failing master lint #3640
Fix failing master lint #3640
Conversation
| @@ -21,7 +21,8 @@ | |||
| "link-check": "repo-link-check -c config/link-check/config.yml", | |||
| "link-check-diff": "repo-link-check -c config/link-check/config.yml -d master", | |||
| "link-check-dev-server": "repo-link-check -c config/link-check/config.yml -r http://localhost:3000", | |||
| "link-check-exclude": "repo-link-check -c config/link-check/config.yml --unused-patterns-only" | |||
| "link-check-exclude": "repo-link-check -c config/link-check/config.yml --unused-patterns-only", | |||
| "prepare": "husky install" | |||
There was a problem hiding this comment.
Husky works different after v8! See husky docs
| @@ -111,7 +112,6 @@ | |||
| "@types/react-instantsearch-dom": "^6.12.3", | |||
| "@types/react-popover": "^0.5.3", | |||
| "@types/react-slick": "^0.23.8", | |||
| "@types/rehype-react": "^6.0.0", | |||
There was a problem hiding this comment.
Noticed that we no longer need this package and deleted it.
| @@ -1,4 +1,4 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Some errors were simple to fix.
| @@ -1,17 +1,17 @@ | |||
| .cmlIcon { | |||
There was a problem hiding this comment.
Not sure how stylelint missed this but it's fixed now!
| @@ -20,6 +24,7 @@ const Popover: React.FC<IPopoverProps> = ({ children, ...restProps }) => { | |||
| const close = (): void => setOpened(false) | |||
|
|
|||
| return ( | |||
| // @ts-expect-error Error is caused by package and out of our control | |||
There was a problem hiding this comment.
I couldn't figure out how to clear this error because it seemed to be caused by the fact that ReactPopover doesn't expect children. But the package here isn't very well maintained... The only thing I could come up with was ignoring the error but does anyone have a better alternative?
No overload matches this call.
Overload 1 of 2, '(props: PopoverProps | Readonly<PopoverProps>): Popover', gave the following error.
Type '{ children: Element; body: ReactNode; enterExitTransitionDurationMs: number; isOpen: boolean; onOuterAction: () => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Popover> & Readonly<PopoverProps>'.
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Popover> & Readonly<PopoverProps>'.
Overload 2 of 2, '(props: PopoverProps, context: any): Popover', gave the following error.
Type '{ children: Element; body: ReactNode; enterExitTransitionDurationMs: number; isOpen: boolean; onOuterAction: () => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Popover> & Readonly<PopoverProps>'.
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Popover> & Readonly<PopoverProps>'.
| @@ -21,5 +21,6 @@ | |||
| "alwaysStrict": true, | |||
| "noEmit": true | |||
| }, | |||
| "include": ["./src/**/*", "./*.js"] | |||
| "include": ["./src/**/*", "./*.js"], | |||
| "exclude": ["./node_modules/**/*"] | |||
| } | |||
There was a problem hiding this comment.
A good chunk of errors were based around PACKAGE_NAME cannot be used as a JSX component or NODE_MODULE PATH.ReactNode' is not assignable to type 'React.ReactNode'.
I found this StackOverflow thread but adding resolutions didn't work. I ended up deleting yarn.lock and reinstalling which cleared all the errors. I looked over the site and everything looks built correctly 🤔 But if anyone has a better idea to clearing the errors, please let me know!
node_modules/@dvcorg/gatsby-theme-iterative/src/components/MainLayout/index.tsx:59:9 - error TS2322: Type 'import("/home/circleci/repo/node_modules/@dvcorg/gatsby-theme-iterative/node_modules/@types/react/index").ReactNode' is not assignable to type 'React.ReactNode'.
node_modules/@dvcorg/gatsby-theme-iterative/src/components/Page/DefaultSEO/index.tsx:105:6 - error TS2786: 'Helmet' cannot be used as a JSX component.
Its instance type 'Helmet' is not a valid JSX element.
|
Thanks! |
Not sure when everything started breaking. Husky probably broke when #3396 was merged since that was when husky was upgraded. Maybe the CSS lint and TS lint broke at that time as well since we did upgrade a lot of different packages 🤔 Have to run some tests to be sure!